Skip to content

Conversation

@aVolpe
Copy link
Contributor

@aVolpe aVolpe commented Nov 30, 2022

This is a work in progress, this is too disruptive to be applicable/useful, but I want to make this pr so if in a future
we make the jump we don't start from scratch.

This PR bumps the dependency of hibernate from 5 to 6, this is not a minor change because there
was a change in package, from javax.persistence to jakarta.persistence (more info).

Hibernate 6 also needs java at least 11.

This package change will also affect the qi and rest modules, jetty should be upgraded to 11.

Progress:

  • minigl: update to hibernate 6
  • minigl: migrate from hibernate criteria to jpa criteria, hibernate criteria was removed
  • minigl: migrate from hql to jpql, some constructs from hql were removed.
  • minigl: all tests pass
  • minigl: all tests pass with postgres
  • minigl: all tests pass with mysql
  • minigl: there are some issues with the journal export, it doesn't work without cache lvl2.
  • dbsupport: update to hibernate 6
  • dbsupport: update to hibernate-ehcache 6. Currently, there are no stable modules for ehcache for hibernate 6.
  • rest modules: update to jetty 11
  • qi/vaadin modules: update to jetty 11
  • global: re-enable testbed
  • remove dom4j, this library has some problems with java 17 and we can use jdom2 which is already used in jpos.

This commit is big because:

* The package javax.persistence is removed, the new package
  jakarta.persistence is used everywhere.
* Hibernate 6 removes it custom criteria builder api, so we need to
  migrate everything to jpa criteria query.

Signed-off-by: Arturo Volpe <avolpe@fintech.works>
The eh-cache should be enabled in a different way, the previous package
is currently in Alpha.

Signed-off-by: Arturo Volpe <avolpe@fintech.works>
Signed-off-by: Arturo Volpe <avolpe@fintech.works>
Signed-off-by: Arturo Volpe <avolpe@fintech.works>
Signed-off-by: Arturo Volpe <avolpe@fintech.works>
Signed-off-by: Arturo Volpe <avolpe@fintech.works>
Signed-off-by: Arturo Volpe <avolpe@fintech.works>
Signed-off-by: Arturo Volpe <avolpe@fintech.works>
Signed-off-by: Arturo Volpe <avolpe@fintech.works>
Signed-off-by: Arturo Volpe <avolpe@fintech.works>
@ar
Copy link
Member

ar commented Nov 30, 2022

A change like this deserves the release of 2.2.9 and a move to 2.3.0. We can do it once you're ready with this PR.

Signed-off-by: Arturo Volpe <arturovolpe@gmail.com>
Signed-off-by: Arturo Volpe <arturovolpe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants