Skip to content

Conversation

@jpmcmu
Copy link
Owner

@jpmcmu jpmcmu commented Apr 5, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

GordonSmith and others added 30 commits December 19, 2023 15:04
Causes an issue with Ubuntu 23.10 + upstream #include <chrono>

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
Signed-off-by: Shamser Ahmed <shamser.ahmed@lexisnexis.com>
…MEMBED_CHRONO

HPCC-31034 wasmembed has problematic includes

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-30599 Fix file access costs for keyed join

Reviewed-by: Jake Smith <jake.smith@lexisnexisrisk.com>
Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
…tartTimeOverride

HPCC-30374 Provide JTrace option to declare span start time

Reviewed-By: Anthony Fishbeck <anthony.fishbeck@lexisnexisrisk.com>
Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
…9.4.x

Signed-off-by: Jake Smith <jake.smith@lexisnexisrisk.com>
This also closes a few paths in k8s where an early error,
e.g. an error during worker registration, would not be
correctly reported back to the workunit, and cause the
agent to be unaware of the failure and deadlock.

Signed-off-by: Jake Smith <jake.smith@lexisnexisrisk.com>
In the existing code, a 'lost' file found by XRef can't be deleted
if that file is a sub of a super file without manually being removed
from the super file. With this option is set inside delete request,
the file will be automatically removed from its owning super files
before the 'lost' file is deleted.

Signed-off-by: wangkx <kevin.wang@lexisnexis.com>
- Renames invalid GRCP to GRPC

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexisrisk.com>
Signed-off-by: Jake Smith <jake.smith@lexisnexisrisk.com>
…9.4.x

Signed-off-by: Jake Smith <jake.smith@lexisnexisrisk.com>

# Conflicts:
#	helm/hpcc/Chart.yaml
#	helm/hpcc/templates/_helpers.tpl
#	helm/hpcc/templates/dafilesrv.yaml
#	helm/hpcc/templates/dali.yaml
#	helm/hpcc/templates/dfuserver.yaml
#	helm/hpcc/templates/eclagent.yaml
#	helm/hpcc/templates/eclccserver.yaml
#	helm/hpcc/templates/eclscheduler.yaml
#	helm/hpcc/templates/esp.yaml
#	helm/hpcc/templates/localroxie.yaml
#	helm/hpcc/templates/roxie.yaml
#	helm/hpcc/templates/sasha.yaml
#	helm/hpcc/templates/thor.yaml
#	version.cmake
…geStats

Prior to this change, it wasn't possible to share a IContextLogger
between different CKeyLevelManager.  The reason was that a
mergeStats call needed to made of each of the CKeyLevelManagers
but each call to the CKeyLevelManager::mergeStat would have the
same jhtree stats being merged.

By removing the IContextLogger merge from CKeyLevelManager::mergeStats
it is possible for the same IContextLogger to be shared between
different CKeyLevelManagers.  This change required, the caller to
merge the stats from the IContextLogger.

This change make the IndexRead activity jhtree stats change
simpler and more efficient as it can use the same IContextLogger from
the different file parts.)

Signed-off-by: Shamser Ahmed <shamser.ahmed@lexisnexis.com>
Signed-off-by: g-pan <greg.panagiotatos@lexisnexis.com>
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
…RCP-GRPC-Typo

HPCC-31041 Fix JTrace GRCP typo

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
…l_94

HPCC-30214 Use openssl aes encrypt/decrypt functions

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-29461 Update Copyright Year

Reviewed-By: Jim DeFabia <jamesdefabia@lexisnexis.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-30928 Improve compressToBuffer using LZ4

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
…tration-timeout

HPCC-31009 Ensure Thor startup errors are properly reported.

Reviewed-By: Shamser Ahmed <shamser.ahmed@lexisnexis.com>
Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Signed-off-by: Jim DeFabia <jamesdefabia@lexisnexis.com>
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
HPCC-30299 Update secrets in the background to avoid roxie stalls

Reviewed-By: Anthony Fishbeck <anthony.fishbeck@lexisnexisrisk.com>
Reviewed-by: Mark Kelly mark.kelly@lexisnexisrisk.com
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
Also reduce tracing when acks required, and report required acks via stats

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
…riority

HPCC-30961 Roxie out-of-band packets should get sent first

Reviewed-by: Mark Kelly mark.kelly@lexisnexisrisk.com
Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-31061 Roxie queries should not fail after three missing ack's

Reviewed-by: Mark Kelly mark.kelly@lexisnexisrisk.com
Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
ghalliday and others added 19 commits February 27, 2024 13:40
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
…SING_Thrd_sleep_for

HPCC-31355 Windows build failing in GH Actions

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-24527 Document Single User Security Manager

Reviewed-By: Jim DeFabia <jamesdefabia@lexisnexis.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
Some configuration settings are designed for use only while temporarily diagnosing
an issue, and should not be left on permanently due to excessive logging impact.

Generate a warning if such options are set.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-31332 Allow the SOAPCALL PERSIST() parameter to be non-constant

Reviewed-By: Shamser Ahmed <shamser.ahmed@lexisnexis.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-31342 Improve the accuracy of the roxie span elapsed time to ns

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-31095 Report an error if eclcc fails to update the local copy of a git repo

Reviewed-By: Shamser Ahmed <shamser.ahmed@lexisnexis.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
…ptOnWorker

HPCC-31171 Encrypt on worker threads rather than UDP send thread

Reviewed-by: Mark Kelly mark.kelly@lexisnexisrisk.com
Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-31281 Warn if configuration may lead to excessive tracing

Reviewed-by: Mark Kelly mark.kelly@lexisnexisrisk.com
Reviewed-by: Jake Smith <jake.smith@lexisnexisrisk.com>
Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-29889 Fix typo in storage plane name

Reviewed-By: Greg Panagiotatos <greg.panagiotatos@lexisnexis.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-31330 FileAccessCost for dfu workunit incorrectly set

Reviewed-by: Jake Smith <jake.smith@lexisnexisrisk.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
- Added HPCC4j ESP regression suite to K8s regression suite

Signed-off-by: James McMullan James.McMullan@lexisnexis.com
Repository owner deleted a comment from github-actions bot Apr 5, 2024
Repository owner deleted a comment from github-actions bot Apr 5, 2024
@github-actions
Copy link

github-actions bot commented Apr 5, 2024

ESP Regression Suite Test Failures:

The following tests failed; checkout a copy of the HPCC4j project with the following command and run the individual test commands below to debug the failures.

git clone https://github.com/BrokenTests.git hpcc4j
cd hpcc4j && git checkout BrokenTests

org.hpccsystems.ws.client.WsDFUClientTest.testGetFiles Failed

Error: Example error
Test Command: mvn -B -Dhpccconn=https://eclwatch.default:8010 -Dtest=org.hpccsystems.ws.client.WsDFUClientTest#testGetFiles test

org.hpccsystems.ws.client.WsDFUClientTest.testGetFileContent Failed

Error: Example error
Test Command: mvn -B -Dhpccconn=https://eclwatch.default:8010 -Dtest=org.hpccsystems.ws.client.WsDFUClientTest#testGetFileContent test

org.hpccsystems.ws.client.WUQueryTest.testGetWorkunitByAppName Failed

Error: Example error
Test Command: mvn -B -Dhpccconn=https://eclwatch.default:8010 -Dtest=org.hpccsystems.ws.client.WUQueryTest#testGetWorkunitByAppName test

org.hpccsystems.ws.client.WSWorkunitsTest.testMultipleWsWUInits Failed

Error: Example error
Test Command: mvn -B -Dhpccconn=https://eclwatch.default:8010 -Dtest=org.hpccsystems.ws.client.WSWorkunitsTest#testMultipleWsWUInits test

@jpmcmu jpmcmu force-pushed the master branch 2 times, most recently from a86b0f5 to 6df0e81 Compare August 8, 2024 18:46
@jpmcmu jpmcmu force-pushed the master branch 4 times, most recently from 19a215f to 399906f Compare September 20, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.