Conversation
Extend haptic feedback system to provide tactile responses for more sheet and modal presentations throughout the app. Changes: - UserProfileBottomSheetView: Add light impact on open/close in NationalRankingView, TeamRankingView, and GroupDetailView - BadgeDetailView: Add light impact on open/close for all three badge view types (BadgeItemView, BadgeCardButton, Simple3DBadgeView) - MissionSection: Add light impact when opening/closing mission detail sheet - GroupDetailView: Add light impact when opening/closing group detail sheet All feedback follows the same pattern: light impact on open and light impact on close, providing consistent tactile response across the app.
Add tactile feedback when users flip the badge to see the back side in BadgeDetailView's RotatableBadgeView component. Changes: - RotatableBadgeView: Medium impact haptic when badge is flipped, providing stronger feedback for this more significant 3D interaction
Fix build errors where IdentifiableUUID needs to conform to Equatable to work with SwiftUI's onChange(of:) modifier. Changes: - NationalRankingView: Add Equatable conformance to IdentifiableUUID - TeamRankingView: Add Equatable conformance to IdentifiableUUID This fixes the compilation errors: "referencing instance method 'onChange(of:initial:_:)' on 'Optional' requires that 'IdentifiableUUID' conform to 'Equatable'"
Riochin
approved these changes
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Extend haptic feedback system to provide tactile responses for more sheet and modal presentations throughout the app.
Changes:
All feedback follows the same pattern: light impact on open and light impact on close, providing consistent tactile response across the app.
Related Issue
Changes
How to Test
Build & Run
Screenshots/Videos
Points for Review