Open
Conversation
Owner
|
@sangaline Sent you a message on linkedin - but in the meantime, looks like I need to update some typing stuff, and upgrade our prospector config! |
Owner
|
Okay I've fixed a lot of the prospector and typing stuff in #130 , could you rebase and rerun the CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new Webhooks client that can be used to manage webhook settings and subscriptions using the Hubspot Webhooks API. This API has different requirements from the other API clients, namely it requires the use of an API key for the developer account where the webhook subscriptions live; oauth authentication won't work, nor will the legacy API key or private app access token from a non-developer account. Conversely, the developer account API key cannot be used to access anything from a non-developer account (e.g. contacts, deals, companies). The API also requires that an
app_idbe specified when initializing the client, for example:As a side note, the API keys for non-developer accounts are being officially sunset tomorrow and will stop working for anybody who didn't specifically get an extension. This might suggest that the
api_keyparameter should be phased out, but it's worth noting that it's deprecation is only for non-developer accounts and this PR is an example of how the parameter continues to be useful moving forward.