Gradle build scripts added, to work with Java/JavaFX 11+#1
Open
chirontt wants to merge 1 commit intojperedadnr:masterfrom
Open
Gradle build scripts added, to work with Java/JavaFX 11+#1chirontt wants to merge 1 commit intojperedadnr:masterfrom
chirontt wants to merge 1 commit intojperedadnr:masterfrom
Conversation
- build script uses JDK 11+ to compile the code with JavaFX 11+ - RubikFX.java code updated to work with JavaFX dialogs, making the controlsfx library redundant, and thus the controlsfx library is removed from the project - 3DViewer library re-compiled with JavaFX 11+ libraries, and renamed to Viewer3D.jar, to avoid runtime error like: 3DViewer: Invalid module name: '3DViewer' is not a Java identifier when put on the module path, even though it's not a module - a simple Launcher class is added to the project, to be used with an executable fat jar built from the project, with no module path setup needed at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build script uses JDK 11+ to compile the code with JavaFX 11+
RubikFX.java code updated to work with JavaFX dialogs, making the
controlsfx library redundant, and thus the controlsfx library is removed
from the project
3DViewer library re-compiled with JavaFX 11+ libraries, and renamed to
Viewer3D.jar, to avoid runtime error like:
3DViewer: Invalid module name: '3DViewer' is not a Java identifier
when put on the module path, even though it's not a module
executable fat jar built from the project, with no module path setup
needed at runtime.