Added support for all mobs through Minecraft 1.21.11#139
Open
wesleyegbertsen wants to merge 14 commits intojpenilla:masterfrom
Open
Added support for all mobs through Minecraft 1.21.11#139wesleyegbertsen wants to merge 14 commits intojpenilla:masterfrom
wesleyegbertsen wants to merge 14 commits intojpenilla:masterfrom
Conversation
…ntifier error: invalid path 'addons/mobs/src/main/resources/icons/trader_llama.png:Zone.Identifier'
The actual code checks if the Y location of the mob is lower than the hightest block Y location of the XZ location of the mob. So the function name was not correct.
…nautilus` are not in the default passive/neutral mobs list
…comes passive once their hostile mob rider gets separated from them
Author
|
I've enabled the workflows on the fork I did on this repository, noticed I missed some mobs so added them and those changes triggered the build workflows. So if anyone is interested in already using the updated mobs plugin, you can find the as of this moment latest ran workflow here: https://github.com/wesleyegbertsen/squaremap-addons/actions/runs/20685005220 and download the build artifacts. Or just download the build artifacts via this link: https://github.com/wesleyegbertsen/squaremap-addons/actions/runs/20685005220/artifacts/5015426045 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Remarks
I've been playing on a self-hosted Minecraft server with my little brother. Since it's self hosted on a NAS, the lightweight nature of squaremap is really nice. I noticed though that some mobs were not showing with this addon in the map viewer. So I've made some changes to support all missing mobs.
Summary
allowed-mobs.allowed-mobs(the icons files were there too already), but they were not part of the default list ofallowed-mobs. Since the default list implies it's all passive/neutral mobs by default. I added these mobs to the default list.Icons.registeraboveSurfacetobelowSurfaceto match behavior.trader_llama.png:Zone.Identifierfile.git clonefail onWindowsat least.error: invalid path 'addons/mobs/src/main/resources/icons/trader_llama.png:Zone.Identifier'1.1.0-SNAPSHOTTesting
I've built the mobs plugin on my machine, and tested the changed plugin on my self hosted server on my NAS. So actually spawned in newly added mobs, to verify if shown in the map viewer.