Skip to content

Support per-track linewidth in TracksMesh #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joyy-7921 wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Support per-track linewidth in TracksMesh #1

joyy-7921 wants to merge 15 commits into from

Conversation

@joyy-7921
Copy link
Owner

@joyy-7921 joyy-7921 commented Dec 2, 2025

Description

Modified TracksMesh to support a linewidth attribute per track, allowing for variable line widths as set by JiveXMLLoader.

Changes

packages/phoenix-event-display

  • tracks.ts:
    • Added linewidths array to TracksMesh.
    • Updated addTrack to accept linewidth and store it.
    • Updated process to create a linewidth BufferAttribute.
    • Updated tracks_vert shader to use attribute float linewidth instead of uniform.
  • phoenix-objects.ts:
    • Updated getTracks to pass track.linewidth to tracksMesh.addTrack.

Verification Results

Automated Tests

  • Ran existing tests in phoenix-objects.test.ts: PASSED
  • Created and ran new tests in tracks.test.ts: PASSED
yarn workspace phoenix-event-display test src/tests/loaders/objects/tracks.test.ts

EdwardMoyse and others added 15 commits November 1, 2025 15:10
@EdwardMoyse
Remove debug log
bcaed11
@EdwardMoyse
Update TS version to 5.9
59e3301
@EdwardMoyse
Update webpack and minor angular update
01b55ec
@EdwardMoyse
Update angular
ace674c
@EdwardMoyse
Update @typescript-eslint
0a8c163
@EdwardMoyse
Update angular part 2
c4c7143
@EdwardMoyse
Updating babel etc
b88950c
@EdwardMoyse
Rebased to main
9c5a7bc
@EdwardMoyse
Update checkout code action to hopefully get more recent node version
004ab13
@joyy-7921
feat(event-display): remove Angular dependency and add framework-agno…
e91f095 
…stic EventEmitter

- Created framework-independent EventEmitter class to replace Angular's EventEmitter
- Removed Angular dependency from phoenix-event-display library
- Fixed Jest configuration (jest.conf.js -> jest.conf.cjs, corrected setup paths)
- Added comprehensive mocks for three.js ESM examples to resolve test issues
- Created test suite for EventEmitter with full coverage
- All tests now passing (345/345 tests, 83/83 test suites)

This change makes phoenix-event-display truly framework-agnostic and improves
the library's architecture by removing the Angular framework dependency.
@joyy-7921
Fix phoenix-ng:test:ci failure: resolve type mismatches and update mocks
1ca5278
@joyy-7921
fix: resolve prettier errors in jest.conf.cjs
4bcf003
@EdwardMoyse
Add missing documentation
4dabe7b
@EdwardMoyse
Add missing documentation
e69fea6
@joyy-7921
feat: support per-track linewidth in TracksMesh
c03c0a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joyy-7921 @EdwardMoyse