Misssing <resource> symbolic link handling in "TranslateLVSymbolicTokenToPath.vim"#64
Open
AndreaV-Lsi wants to merge 2 commits intojovianarts:mainfrom
Open
Misssing <resource> symbolic link handling in "TranslateLVSymbolicTokenToPath.vim"#64AndreaV-Lsi wants to merge 2 commits intojovianarts:mainfrom
AndreaV-Lsi wants to merge 2 commits intojovianarts:mainfrom
Conversation
…with a change history of the Top-level Library This addresses Bug jovianarts#61 When we edit a PPL build specification and we change the "Top-level library" from say "Library A.lvlib" to "Library B.lvlib", and we don't assign "Library A.lvlib" to "Always Included", traces of "Library A.lvlib" are left in the project XML file build specification filed in the "Source" array. This results in the fact that the Source[%d].sourceInclusion .neq. "Exclude" will yield TRUE while the"Library A.lvlib" is not included in the build specification. For this reason, we OR compound the .neq. check with an "Empty String/Path?" check. If we don't do this, we end up with spurious inclusions that can cause bogus circular dependencies Source code was edited in LabVIEW 2019 SP1. Failing Unit Tests were failing before the fix
"TranslateLVSymbolicTokenToPath.vim" doesn't handle the <resource> symbolic path. This means that LabVIEW Solution Builder doesn't detect dependencies on libraries in <resource>. Handling of <resource> was added to "TranslateLVSymbolicTokenToPath.vim" This Closes jovianarts#63
AndreaV-Lsi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR Closes #63 . "TranslateLVSymbolicTokenToPath.vim" doesn't handle the <resource> symbolic path. This means that LabVIEW Solution Builder doesn't detect dependencies on libraries in <resource>. After the fix, this is the result of executing LabVIEW Solution Builder to build the example project attached to the bug report.
High-level Checklist (if any apply):
"TranslateLVSymbolicTokenToPath.vim" was edited by adding the "resource" case to the case structure by duplicating the "userlib" case and suitably editing it.
Why should this Pull Request be merged?
This bug might affect projects that need to build PPLs out of libraries residing in the <resource> folder
What testing has been done?
/src/_tests/RunTheTests.viand all tests passedAll the test passing before the bugfix pass after the bugfix.
What Release Build Should This Go In?