Support creating and deleting indexes, and creating items in ElasticSearch#1
Open
willemnviljoen wants to merge 57 commits intojotweh:masterfrom
Open
Support creating and deleting indexes, and creating items in ElasticSearch#1willemnviljoen wants to merge 57 commits intojotweh:masterfrom
willemnviljoen wants to merge 57 commits intojotweh:masterfrom
Conversation
added 30 commits
November 24, 2015 10:34
…IndexNameToClient
…existing codebase
added 27 commits
November 24, 2015 12:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in my develop branch allow the user to create and delete indexes in ElasticSearch, and also to post items to an index, with assertions that indexes exist or don't exist.
I've also brought all the existing code under test and made it compatible with Codeception 2.1. If these changes are applied, Codeception 2.1 becomes a requirement.
There was also one thing I wanted to ask about. Currently, seeItemExistsInElasticsearch only returns a boolean, rather than creating an assertion that it must exist, which is the standard for Codeception. I haven't changed that, as I don't want to break any existing behaviour.