Remove surplus newlines (fixes #59) #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do a `flat_map_reduce` over the list of children and filter out any child that is either `[]` or `nil`. The `count` is required to properly detect the first non-blank item, which shouldn't be prefixed with a new-line. As the code is used in both `format` and `format_content`, factor it out into `format_children`. Fixes: joshnuss#59
mneumann
force-pushed
the
remove-surplus-newlines-59
branch
from
42df639 to
9b5ee43
Compare
joshnuss
reviewed
Mar 25, 2025
Owner
joshnuss
left a comment
joshnuss
left a comment
There was a problem hiding this comment.
Looks great!
Left 2 small comments.
Owner
|
Thanks @mneumann!! Much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59