Fix cache to store full session list, filter post-cache#342
Merged
joshmedeski merged 1 commit intomainfrom Feb 21, 2026
Merged
Conversation
The CachingLister was passing source filters and HideDuplicates through to the inner lister, causing the cache to store partial results. Subsequent calls with different filters (e.g. --tmux then --zoxide) would return incorrect data from cache. Now the inner lister always fetches all sources without dedup, and source filtering, HideDuplicates, and HideAttached are all applied as post-cache filters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CachingListerwas passing source filters (--tmux,--zoxide, etc.) andHideDuplicatesthrough to the inner lister, causing the cache to store partial results. Subsequent calls with different filters returned incorrect data from cache (e.g.sesh list --tmuxthensesh list --zoxidewould return tmux sessions for both).HideDuplicates, andHideAttachedare all applied as post-cache filters inapplyFilters.Test plan
just test— all existing + new tests passcache = truein config, runsesh list --tmuxthensesh list --zoxideand confirm each returns the correct source🤖 Generated with Claude Code