🌐 i18n(README): Add the simplified Chinese version of README#330
🌐 i18n(README): Add the simplified Chinese version of README#330joshmedeski merged 2 commits intojoshmedeski:mainfrom
Conversation
joshmedeski
left a comment
joshmedeski
left a comment
There was a problem hiding this comment.
Thanks for doing this! Glad to see this translated so others can use it.
Would you allow me to add you as a code reviewer for future PRs if/when we update the READMEs to make sure the documents don't go out of sync?
Just one suggestion about rendering callouts, but otherwise it seems okay.
README.zh-cn.md
Outdated
| dir_length = 2 # 使用最后两个目录："projects/sesh" 而不是 "sesh" | ||
| ``` | ||
|
|
||
| > [!注意] |
There was a problem hiding this comment.
[!警告] -- the English uses > [!WARNING], which is a GitHub-specific admonition syntax.
Translating the keyword may break the rendering on GitHub. The > [!NOTE] on line 408 has the same issue
(> [!注意]). These keywords should stay in English for proper GitHub rendering.
joshmedeski
left a comment
joshmedeski
left a comment
There was a problem hiding this comment.
Please address that callout note and I'll be good to merge it.
There was a problem hiding this comment.
Pull request overview
Adds Simplified Chinese documentation for the project and links it from the main README to improve accessibility for Chinese-speaking users.
Changes:
- Added a new
README.zh-cn.md(Simplified Chinese) translation of the README content. - Added a language switcher block to
README.mdlinking to the Chinese README.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| README.zh-cn.md | Introduces a full Simplified Chinese README (translation of existing docs and usage examples). |
| README.md | Adds a centered language selector linking to README.zh-cn.md. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| bind-key "K" display-popup -E -w 40% "sesh connect "$( | ||
| sesh list -i | gum filter --limit 1 --no-sort --fuzzy --placeholder 'Pick a sesh' --height 50 --prompt='⚡' | ||
| )"" |
There was a problem hiding this comment.
The gum+tmux example has the same quoting issue as the tmux+fzf snippet: "sesh connect "$( breaks the string, and the closing quotes won’t match. Please wrap the $(...) in escaped quotes (as in README.md) so the command is valid when pasted.
| bind-key "K" display-popup -E -w 40% "sesh connect "$( | |
| sesh list -i | gum filter --limit 1 --no-sort --fuzzy --placeholder 'Pick a sesh' --height 50 --prompt='⚡' | |
| )"" | |
| bind-key "K" display-popup -E -w 40% "sesh connect \"$(sesh list -i | gum filter --limit 1 --no-sort --fuzzy --placeholder 'Pick a sesh' --height 50 --prompt='⚡')\"" |
README.zh-cn.md
Outdated
| ``` | ||
|
|
||
| > [!注意] | ||
| > 与 [tmux-floatx](https://github.com/omerxx/tmux-floax) 配合使用效果很好 |
There was a problem hiding this comment.
The link text and URL don’t match: the text says tmux-floatx but the URL points to tmux-floax. Please align them to the correct project name to avoid confusing readers.
| > 与 [tmux-floatx](https://github.com/omerxx/tmux-floax) 配合使用效果很好 | |
| > 与 [tmux-floax](https://github.com/omerxx/tmux-floax) 配合使用效果很好 |
|
谢谢 Thanks! |
Hey, I added a Chinese document so that more people can know about this project.