refactor: extract PlayerView into smaller reusable components#27
Merged
refactor: extract PlayerView into smaller reusable components#27
Conversation
Extract PlayerView (597 lines) into focused, composable components: New components: - PlayerActions: Callback container for player actions - PlayerProgressState: Timer-based progress tracking (@observable) - ThemeController: Theme switching + swipe gesture (@observable) - PlaybackStateContent: Generic switch eliminator for PlaybackState - SongInfoDisplay: Song title/artist/progress display - PlayerTopBar: Add/Settings buttons - PlayerControlsPanel: ClickWheel in ShuffleBody wrapper - ClassicPlayerLayout: Composes all components into current layout Benefits: - PlayerView main struct reduced to ~143 lines (orchestration only) - Eliminates 4 duplicate switch statements on PlaybackState - Separates timer/gesture/lifecycle code from view code - Makes layout experimentation straightforward (swap ClassicPlayerLayout) - Each component is independently testable and reusable Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New Components
PlayerActions.swiftPlayerProgressState.swiftThemeController.swiftPlaybackStateContent.swiftSongInfoDisplay.swiftPlayerTopBar.swiftPlayerControlsPanel.swiftClassicPlayerLayout.swiftBenefits
ClassicPlayerLayoutfor alternatives)Test plan
🤖 Generated with Claude Code