fix: properly handle durations across the login url generation flows#51
Merged
fix: properly handle durations across the login url generation flows#51
Conversation
Fixes a bug with inadvertently applying an overly aggressive 15m default session duration during user federation. Fixes (or works around) an edge case using a session duration during login url generation when using chained role credentials.
Owner
Author
|
I also performed some extensive testing with respect to Console session lifespans when using different flavors of input credentials; There seems to be a (as far as I can tell, undocumented) Console session limit of 15 minutes when using role-chained credentials (despite the credentials themselves being valid for 1 hour). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug with inadvertently applying an overly aggressive 15m default session duration during user federation.
Fixes (or works around) an edge case using a session duration during login url generation when using chained role credentials.
Resolves #42