Remove Jquery, Shake improvements#13
Open
brewer-apex wants to merge 3 commits intojosephgruber:mainfrom
Open
Conversation
Owner
|
There seems to be an issue where an additional click is needed between "shakes" now (see the video below). Also, the rotation effect doesn't seem natural. Going back to the discussion in Slack, I was thinking more of a zoom effect (8-ball shrinks and grows several times to emulate the natural shake effect). I don't know if that's what you were aiming for with the rotation effect. Screenshot_20250915_002685.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Jquery in favor of vanilla js and improves the shake animation with arbitrary direction and rotation.