Conversation
7460d44 to
ba12d8b
Compare
There was a problem hiding this comment.
Pull request overview
Adds a static-serve fallback to the development router so glaze serve --static can serve pre-built public/ HTML through the same dev-router.php entrypoint as live mode, controlled via a new GLAZE_STATIC_MODE environment flag.
Changes:
- Introduces
StaticPageRequestHandlerto serve pre-builtindex.htmlpages + static 404 handling (basePath-aware, redirecting directory paths to trailing slashes). - Updates
ServeCommand/PhpServerProcessto always usedev-router.phpand passGLAZE_STATIC_MODEinto the PHP server process. - Updates/expands unit + integration tests to reflect router requirements and static-mode behavior.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/Http/StaticPageRequestHandler.php |
New request handler serving pre-built static HTML in static-serve mode. |
bin/dev-router.php |
Switches fallback handler based on GLAZE_STATIC_MODE (static vs live). |
src/Command/ServeCommand.php |
Sets router env for both modes; disables Vite in static mode unless explicitly requested (then errors). |
src/Process/PhpServerProcess.php |
Always builds PHP server command with router; forwards GLAZE_STATIC_MODE. |
tests/Unit/Http/StaticPageRequestHandlerTest.php |
New unit tests covering static handler routing/redirect/basePath behavior. |
tests/Unit/Process/PhpServerProcessTest.php |
Updates tests for router-required behavior + env forwarding changes. |
tests/Unit/Command/ServeCommandTest.php |
Updates environment/Vite resolution tests to include static-mode semantics. |
tests/Integration/Command/ServeCommandTest.php |
Aligns expected router-missing error message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.