Skip to content

Refactor JWT support for firebase/php-jwt ^7.0 and clean PHPUnit 13 output#2

Merged
josbeir merged 2 commits intomainfrom
update-firebase-jwt7
Feb 25, 2026
Merged

Refactor JWT support for firebase/php-jwt ^7.0 and clean PHPUnit 13 output#2
josbeir merged 2 commits intomainfrom
update-firebase-jwt7

Conversation

@josbeir
Copy link
Copy Markdown
Owner

@josbeir josbeir commented Feb 25, 2026

Summary

  • Upgrades JWT dependency to firebase/php-jwt ^7.0 (now on v7.0.2).
  • Adds explicit HMAC secret length validation in FirebaseTokenFactory:
    • HS256 >= 32 bytes
    • HS384 >= 48 bytes
    • HS512 >= 64 bytes
  • Updates docs/config notes to document the new minimum secret lengths.
  • Updates affected tests with compliant secrets and adds coverage for short-secret validation.

PHPUnit 13 cleanup

  • Removes apc.enable_cli ini override from PHPUnit config to avoid runner warning.
  • Replaces mock objects without expectations with stubs in middleware tests to remove PHPUnit notices.

Copilot AI review requested due to automatic review settings February 25, 2026 14:42
@codecov-commenter
Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@josbeir josbeir force-pushed the update-firebase-jwt7 branch from 6ae3bea to 84a3572 Compare February 25, 2026 14:44

This comment was marked as outdated.

@josbeir josbeir merged commit 4258dc3 into main Feb 25, 2026
6 checks passed
@josbeir josbeir deleted the update-firebase-jwt7 branch February 25, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants