Add reacquireOnPageVisible functionality#279
Merged
jorisre merged 2 commits intojorisre:mainfrom Apr 1, 2025
Merged
Conversation
- Implement `reacquireOnPageVisible` option in the hook - Add tests to verify `reacquireOnPageVisible` functionality - Solves issue jorisre#273
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Added documentation and updated the usage example
jorisre
approved these changes
Apr 1, 2025
Owner
jorisre
left a comment
jorisre
left a comment
There was a problem hiding this comment.
LGMT! Thanks for the contribution!
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
calebchiam
reviewed
Apr 15, 2025
| React.useEffect(() => { | ||
| if (reacquireOnPageVisible) { | ||
| const handleVisibilityChange = async () => { | ||
| if (wakeLock.current && document.visibilityState === 'visible') { |
Contributor
There was a problem hiding this comment.
@Deftera186 @jorisre hey folks, I might be missing something here, but shouldn't this check for if (wakeLock.current === null && document.visibilityState === 'visible') instead?
Navigating away from the page triggers wakeLock.current.onrelease, which then sets wakeLock.current = null.
Returning to the page then should check for wakeLock.current === null, before attempting to reacquire the lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reacquireOnPageVisibleoption in the hookreacquireOnPageVisiblefunctionality