Open
Conversation
dmyTRUEk
reviewed
Nov 29, 2023
dmyTRUEk
reviewed
Nov 29, 2023
dmyTRUEk
reviewed
Nov 29, 2023
|
Overall, looks good to me, if only @jordanbray accepted it... |
|
This looks great and I would love for it to be merged. However, having a PR (#71) open for almost 2 years now with no feedback, I don't think it ever will. Would you guys be interested in forking this crate under a new name? There are a few open PRs that we could merge. I would be happy to help but I don't have much Rust experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request brings the library into the standards and convention of Rust at the time of writing, at least from my point of view.
failuretothiserrorextern crate foo;syntaxconst.I really like this innovative, unconventional use of build.rs, however it also greatly increases build time. It might be possible to replace the build.rs file entirely by clever use of const. It might be even easier, once more operations are available to const.
However the usage of static mut seems unnecessary, but I don't have the time to implement those changes.
On a additional note I think it's sufficient to rely on docs.rs.