Open
Conversation
Sahil3378
approved these changes
Jul 29, 2025
| matrix: | ||
| node-version: [18.x, 20.x, 22.x] | ||
|
|
||
| steps: |
There was a problem hiding this comment.
Thanks for opening this PR! Adding npm-grunt.yml looks like a good step toward automating tasks. I noticed it's targeted at legacy Node.js versions (e.g., 0.10, 0.12), which may not be compatible with current package dependencies.
✅ No merge conflicts — that’s great!
🔁 Suggest testing it on more recent Node versions (e.g., 14, 16) for better compatibility and support.
Let me know if you need help updating the CI matrix! 👨💻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.