Open
Conversation
If GetOptionsFromString returned an error, parse_session_list returned an explicit undef, which isn't treated as an empty hash and resulted in errors like this: ``` Apr 29 19:06:23 haven uberbot[317]: Odd number of elements in hash assignment at /usr/share/perl5/Calvin/Bots/Cambot.pm line 536. Apr 29 19:06:23 haven uberbot[317]: Use of uninitialized value in list assignment at /usr/share/perl5/Calvin/Bots/Cambot.pm line 536. ``` The error from GetOptionsFromString was also reported to standard error. Suppress that with a __WARN__ handler and use a bare return to return an empty list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If GetOptionsFromString returned an error, parse_session_list
returned an explicit undef, which isn't treated as an empty hash
and resulted in errors like this:
The error from GetOptionsFromString was also reported to standard
error. Suppress that with a WARN handler and use a bare return
to return an empty list.