add polyfill for readable stream async iterable support#7
Open
brycedorn wants to merge 1 commit intojonrhall:mainfrom
Open
add polyfill for readable stream async iterable support#7brycedorn wants to merge 1 commit intojonrhall:mainfrom
brycedorn wants to merge 1 commit intojonrhall:mainfrom
Conversation
|
Any reason this isn't being merged? Is this repo being maintained? |
|
I can vouch that @brycedorn 's commit solved streaming issues across different browsers. This commit should be merged. Otherwise, you will have to edit your local openai-streaming-hooks and link it to your app. |
|
This repo is not being maintained by @jonrhall. I switched to https://github.com/SpellcraftAI/openai-streams and have been happy with it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! 👋 As pointed out in #6, the only browser that currently supports async iterable with
ReadableStreamis Firefox:This adds the web-streams-polyfill package to fix behavior for all browsers. Confirmed working with Chrome 114.0.5735.90 and Safari 16.5.