Feature/auto discovery

[shanerutter]

Added ability to auto discover devices on your network and Some PSR-2 clean up

[jonnywilliamson]

This looks good. Give me a chance to have a review and merge.

Thank you!

[jonnywilliamson]

Why are we suppressing warnings here? I'm not keen on that. If there's an error generated we should either deal with it or tell the user.

[jonnywilliamson]

I'm a big fan of Adam Wathan's idea of Refactoring to Collections.

I try to not use foreach loops in the code (I notice there is one actually I forgot to refactor, so I'll do that soon). I'd like to refactor this function and separate it out a little more.

If you're in the mood to have a look at this again that would be great otherwise I'll have a bash at it later.

[jonnywilliamson]

I haven't tested this yet, but i was thinking something along the lines of this:

    /**
     * Will return a collection of all TPLink devices auto discovered
     * on the IP Range given.
     * 
     * These will already have been added to the global config during
     * discovery.
     * 
     * @param     $ipRange
     * @param int $timeout
     *
     * @return Collection
     */
    public function autoDiscoverTPLinkDevices($ipRange, $timeout = 1)
    {
        return collect(Range::parse($ipRange))
            ->map(function ($ip) use ($timeout) {
                $response = $this->deviceResponse($ip, $timeout);

                return is_null($response) ? $response : $this->validTPLinkResponse($response, $ip);
            })
            ->filter();
    }

    /**
     * Try sending systemInfo command to an ip.
     * Possible we may get a blank response, if querying another device which uses these ports
     *
     * @param $ip
     * @param $timeout
     *
     * @return null
     */
    protected function deviceResponse($ip, $timeout)
    {
        try {
            $device = new TPLinkDevice(['ip' => $ip, 'port' => 9999, 'timeout' => $timeout], 'autodiscovery');

            return $device->sendCommand(TPLinkCommand::systemInfo());
        } catch (Exception $exception) {
            return null;
        }
    }

    /**
     * Check the returned data JSON decodes
     * Make sure is not NULL, some devices may return a single character
     * LB100 Series seems to respond on port 9999, however return a bad string
     * TODO:: investigate LB100 support
     *
     * @param $response
     * @param $ip
     *
     * @return mixed|TPLinkDevice
     */
    protected function validTPLinkResponse($response, $ip)
    {
        $jsonResponse = json_decode($response);

        return is_null($jsonResponse) ? $jsonResponse : $this->discoveredDevice($jsonResponse, $ip);
    }

    protected function discoveredDevice($jsonResponse, $ip)
    {
        return $this->newTPLinkDevice([
            'ip'         => (string)$ip,
            'port'       => 9999,
            'systemInfo' => $jsonResponse->system->get_sysinfo,
        ], $jsonResponse->system->get_sysinfo->alias);
    }

[jonnywilliamson]

Thanks for these. Will review this week if I get time, otherwise it'll be the end of next week.

Much appreciated.

[jonnywilliamson]

I haven't forgotten about this

[jonnywilliamson]

@shanerutter You might join me over here: #6