You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This removes the deprecated stdlib validate_ functions and adds Centos/RHEL/Rocky 8 support. Lightly tested on Ubuntu 20 as well and worked as-is with puppet 6 prior to this change so this should work there as well.
As the spec tests were relatively normal, I also took the chance to convert this to puppet pdk style module for easier unit testing. I can split these two changes off into separate PRs if you prefer.
I am seeing the deprecations below @jonmosco
It would be great if we could have a new release with this pull request please.
Warning: This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::String. There is further documentation for validate_legacy function in the README. at ["/etc/puppet/code/modules/logwatch/manifests/init.pp", 28]:["/tmp/mnc/puppet/manifests/site.pp", 0] (location: /etc/puppet/code/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in deprecation')
Warning: This method is deprecated, please use the stdlib validate_legacy function,
with Stdlib::Compat::Array. There is further documentation for validate_legacy function in the README. at ["/etc/puppet/code/modules/logwatch/manifests/init.pp", 30]:["/tmp/mnc/puppet/manifests/site.pp", 0]
(location: /etc/puppet/code/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in deprecation') Warning: This method is deprecated, please use the stdlib validate_legacy function, with Pattern[]. There is further documentation for validate_legacy function in the README. at ["/etc/puppet/code/modules/logwatch/manifests/init.pp", 32]:["/tmp/mnc/puppet/manifests/site.pp", 0] (location: /etc/puppet/code/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in deprecation')
`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the deprecated stdlib validate_ functions and adds Centos/RHEL/Rocky 8 support. Lightly tested on Ubuntu 20 as well and worked as-is with puppet 6 prior to this change so this should work there as well.
As the spec tests were relatively normal, I also took the chance to convert this to puppet pdk style module for easier unit testing. I can split these two changes off into separate PRs if you prefer.