Implemented tag for custom css class for input field#8
Open
vldmr-k wants to merge 1 commit intojoncalhoun:masterfrom
Open
Implemented tag for custom css class for input field#8vldmr-k wants to merge 1 commit intojoncalhoun:masterfrom
vldmr-k wants to merge 1 commit intojoncalhoun:masterfrom
Conversation
Author
|
Is anybody here?) |
Owner
|
Busy, but I'll look at this when I have time. |
joncalhoun
reviewed
Oct 13, 2022
Owner
joncalhoun
left a comment
joncalhoun
left a comment
There was a problem hiding this comment.
I think this should be fine to merge in, but I had a Q about why HTMLEscapeString was used beforehand.
| f.Footer = template.HTML(v) | ||
| } | ||
| if v, ok := tags["class"]; ok { | ||
| f.Class = template.HTMLEscapeString(v) |
Owner
There was a problem hiding this comment.
What is the reasoning behind doing HTMLEscapeString? I'm trying to think of a case where this would have something that needs escaped as part of the class and none are coming to mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.