chore: minor housekeeping - format, ci update, more tests#824
Merged
jonbhanson merged 2 commits intojonbhanson:masterfrom Mar 22, 2026
Merged
chore: minor housekeeping - format, ci update, more tests#824jonbhanson merged 2 commits intojonbhanson:masterfrom
jonbhanson merged 2 commits intojonbhanson:masterfrom
Conversation
- ran dart format on example app - bumped actions/checkout from v2 to v4 - added more parseColor test cases (edge cases for int input, invalid strings, null handling)
ThexXTURBOXx
suggested changes
Mar 21, 2026
Comment on lines
+29
to
+32
| // YAML parses unquoted numeric values like 000000 as int 0 | ||
| expect(parseColor(0), '000000'); | ||
| // YAML parses 123456 as int | ||
| expect(parseColor(123456), '123456'); |
Contributor
There was a problem hiding this comment.
Suggested change
| // YAML parses unquoted numeric values like 000000 as int 0 | |
| expect(parseColor(0), '000000'); | |
| // YAML parses 123456 as int | |
| expect(parseColor(123456), '123456'); | |
| expect(parseColor(0), '000000'); | |
| expect(parseColor(123456), '123456'); |
Co-authored-by: Nico Mexis <nico.mexis@kabelmail.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Just some small cleanup while going through the codebase:
example/lib/main.darthad a minor formatting issue caught bydart formatactions/checkoutfrom v2 to v4 (v2 has been deprecated by GitHub)parseColortests with more edge cases — int inputs from YAML, invalid strings, null handling, etc.Nothing fancy, just keeping things tidy.