Introduce min Android SDK parameter#820
Open
ThexXTURBOXx wants to merge 3 commits intojonbhanson:masterfrom
Open
Introduce min Android SDK parameter#820ThexXTURBOXx wants to merge 3 commits intojonbhanson:masterfrom
ThexXTURBOXx wants to merge 3 commits intojonbhanson:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got the inspiration for this when thinking about
flutter_launcher_icons'smin_sdk_androidparameter and seeing the v21 and v31 folders thatflutter_native_splashgenerates.If the used
minSdkVersionis already 21 or higher, the "default" drawable[-night] folders are redundant as they will not be used anyway. Likewise, if theminSdkVersionis 31 or higher, the values[-night] folders are redundant.This PR tries to get rid of these redundant/unneeded files by simply not generating these configurations and generating the "newer" configurations in their place.
Not the cleanest piece of code, sadly - so I am open for suggestions, of course! :)