Skip to content

Fix to issue 32 when using Ionic v4#33

Open
invot wants to merge 1 commit intojonaszuberbuehler:masterfrom
invot:patch-1
Open

Fix to issue 32 when using Ionic v4#33
invot wants to merge 1 commit intojonaszuberbuehler:masterfrom
invot:patch-1

Conversation

@invot
Copy link
Copy Markdown

@invot invot commented Dec 18, 2019

In Ionic v4 there is no more ion-scroll component, so using this plugin will result in Module not found: Error: Can't resolve 'ionic-angular'

#32

In Ionic v4 there is no more ion-scroll component, so using this plugin will result in `Module not found: Error: Can't resolve 'ionic-angular'`

jonaszuberbuehler#32
@jonaszuberbuehler
Copy link
Copy Markdown
Owner

Hi @invot, thx for the PR. It will prevent the Module not found error but not actually be usable, right? Has been month's since I last had time to look at Ionic 4. Back then, this plugin had to be rewritten completely to make it work (see #26).

@invot
Copy link
Copy Markdown
Author

invot commented Dec 18, 2019

I haven't fully tested it yet but that's the idea. There doesn't seem to be an ion-scroll anymore so pulling that out should help. I should be done testing this by the end of the week. I'll let you know if I see any issues.

@gayali
Copy link
Copy Markdown

gayali commented Mar 3, 2020

changes on adapter-factory.js file, is giving the following errors

ERROR TypeError: this.content.getScrollElement(...).getBoundingClientRect is not a function
    at ContentAdapter.push../node_modules/ion-affix/dist/directives/adapters/content-adapter.js.ContentAdapter.getClientTop (content-adapter.js:20)
    at IonAffix.push../node_modules/ion-affix/dist/directives/ion-affix.js.IonAffix.ngAfterViewInit (ion-affix.js:32)
    at callProviderLifecycles (core.js:28206)
    at callElementProvidersLifecycles (core.js:28171)
    at callLifecycleHooksChildrenFirst (core.js:28153)
    at checkAndUpdateView (core.js:38386)
    at callViewAction (core.js:38742)
    at execComponentViewsAction (core.js:38670)
    at checkAndUpdateView (core.js:38383)
    at callWithDebugContext (core.js:39716)

@leabdalla
Copy link
Copy Markdown

Same problem here. Someone found solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants