Open
Conversation
Fixes the "moc.MocError: /bin/sh: 1: Syntax error: EOF in backquote substitution" error, when trying to play a track that contains a backquote in its filename
moc/__init__.py
Outdated
Owner
There was a problem hiding this comment.
Make _check_file_args not return anything since it doesn't modify the list. This way we can remove the quoted list entirely.
… to check ig files/streams are valid
Owner
|
Could you make a separate pull request for the filename stuff? As for the configuration thing... it might be a better solution to just encapsulate all the logic into a class and keep the configuration file (and other parameters if there are any) as instance state. |
added 2 commits
April 20, 2013 22:20
get_volume gets mixer volume level from moc server by use of socket. We are now parsing moc config file, in order to check where socket file is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better support for backquotes and other nasty characters in file path, using list elements in subprocess.Popen()