Separating GPR from the rest of the surrogate model #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates the GPR from the surrogate model, now its own class as
SurrogateModel. Also changes some nomenclature to make clearer which samples take part in which part of the surrogate model.One of the main goals is to make the GPR layer on top of sklearn as lean as possible, so key parts of the implementation can be changes in isolation from other parts of GPry's code.
If not many attributes are used, it should be backwards-compatible.
It also takes the chance to run a formatter (ruff ~= black) everywhere.
WIP implementation!