Skip to content

Conversation

@kponda
Copy link

@kponda kponda commented Apr 9, 2020

No description provided.

return SetupIntentResult.fromJson(result);
}

static openApplePaySetup() async {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some information why and where this is needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need open ApplePaySetup in somecase and StripePaymentPlugin.m and TPSStripeManager.m implemented this. but I can't call this method and I add openApplePaySetup method in stripe_payment.dart file.

https://github.com/jonasbark/flutter_stripe_payment/blob/master/ios/Classes/StripePaymentPlugin.m#L65
https://github.com/jonasbark/flutter_stripe_payment/blob/master/ios/Classes/TPSStripeManager.m#L877

@klivin
Copy link

klivin commented Dec 2, 2020

This is necessary for any use case involving shipping...can we please merge this?

isoCountryCode: json['ISOCountryCode'] ?? "",
state: json['state'] ?? json['administrativeArea'] ?? "",
city: json['city'] ?? json['locality'] ?? "",
street: json['street'] ?? json['address1'] != null ? json['address1'] + json['address2'] : "",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following line breaks with exception:
street: json['street'] ?? json['address1'] != null ? json['address1'] + json['address2'] : "",
_TypeError (type 'String' is not a subtype of type 'bool')

Needs parens, so change to
json['street'] ?? (json['address1'] != null ? json['address1'] + json['address2'] : "")

tan-nad pushed a commit to tan-nad/stripe_payment that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants