[WIP] Fix dealing presentation selector #46 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emoji and text presentation selector used to request an emoji or text presentation for an emoji charactor.
If an emoji presentation character (EPC) is given,
the emoji should be replaced by corresponding image.
If a text presentation character (TPC) is given,
the emoji shouldn't be replaced by it.
And if an emoji zwj sequence includes TPC, the sequence will be several emojis1.
If an EPC or TPC is not given,
the emoji's expression is determined by the value of its emoji property "Emoji_Presentation".
However, I don't think it makes sense to deal with the Emoji_Presentation property.
For example,
an emoji "🈁" (U+1F201) is
Emoji_Presentation=Yes,but "🈂" (U+1F202) is
Emoji_Presentation=No2.Besides, though many other food emoji are
Emoji_Presentation=Yes,"🌶" is
Emoji_Presentation=No.Do you think this has a meaning?
It's difficult to handle about presentation,
so I think that it is better to ignore emoji and text presentation characters.
And I implemented it.
What do you think?
Thankyou.