Ember cli build was hanging on windows because ", : are invalid characters for the filesystem#16
Open
JoelWAnna wants to merge 1 commit intojoliss:masterfrom
Open
Ember cli build was hanging on windows because ", : are invalid characters for the filesystem#16JoelWAnna wants to merge 1 commit intojoliss:masterfrom
JoelWAnna wants to merge 1 commit intojoliss:masterfrom
Conversation
|
|
||
| CoffeeScriptFilter.prototype.optionsHash = function() { | ||
| if (!this._optionsHash) { | ||
| this._optionsHash = stringify(this.options); |
There was a problem hiding this comment.
i think this should be handled in async-disk-cache via some non-lossy encoding.
There was a problem hiding this comment.
@stefanpenner Would you mind being a bit more clear? Are you suggesting this isn't a workaround you would want to merge into broccoli-coffee? If so, this pull request should probably be closed.
There was a problem hiding this comment.
Now that this has been handled in async-disk-cache, we could probably resolve this issue by upgrading:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doesn't seem that mkdirp will merge the fix to the root cause of this (windows returning ENOENT for
mkdir(folderName)when folder name is invalid)https://github.com/substack/node-mkdirp/pull/74