Open
Conversation
Contributor
|
Hello @williamleferrand, thanks for your contribution and sorry for the delay in getting in touch. Could you explain to me exactly what your proposals are? I saw that you propose some changes. In particular, to
What's the rationale behind? I could share why we did like that with you: As there are a lot of "moving parts (i.e., libraries), the only way to have an "ensemble" that works was by fixing the versions. I'm just worried that installing flash-attention straight from the repo could break things in the (near) future. We are working to increase our number of unit/integration tests to check all of that, by the way. Thanks and best regards, Luiz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces minor install script changes to accommodate a Trixie install.
Tested on Trixie + A4500