Unittests & continuous integration#63
Open
EvaSDK wants to merge 12 commits intojohnsensible:masterfrom
Open
Conversation
As declared upstream at https://www.djangoproject.com/download/#supported-versions Update Trove classifiers and requires/install_requires as a consequence.
jdufresne
reviewed
Apr 10, 2017
Contributor
jdufresne
left a comment
jdufresne
left a comment
There was a problem hiding this comment.
Nice work adding tox support. I believe it is missing Django 1.9 in the envlist.
| skip_missing_interpreters = True | ||
|
|
||
| [testenv] | ||
| changedir = examples/protected_downloads |
Contributor
There was a problem hiding this comment.
In #62 I've fixed the tests so they can be run at the project top level. If that lands, I don't think this changedir will be required.
Author
There was a problem hiding this comment.
Correct, I just picked up from #28, hence the status of this branch.
Author
|
Django 1.9 is EOLed since April, 4th. See https://www.djangoproject.com/download/#supported-versions. |
Contributor
|
Makes sense. Thank you for explanation. |
Closed
Make protected_download app known as download through the AppConfig mechanism. Inspired by Michał Pasternak <mpasternak@MacBook-Pro-Michala.local> commits in PR#66.
six dependency must be added to tox.ini as setup.py will just fail due to version importing code. Atomic commits from PR#66.
Atomic commits from PR#66.
Atomic commits from PR#66.
Signed-off-by: Gilles Dartiguelongue <g.dartiguelongue@lexfo.fr>
Since unicode_literals is imported, there is no need to have this explicit string marker. Also, it breaks with python3.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in other tickets & pull requests, a clean way to test support for multiple versions of Django & Python is needed as some changesets actually brake support for Python 2 or 3 alternatively, etc.
This branch I started a couple of days ago got raced by work in #62 but the purpose here is to bring incremental changes picking up work from other contributors like in #28 and build on that. Also, you retain the ability to test the full matrix locally if you wish with tox (and in parallel with detox).
The net result should end up the same though.
If required, I can also rework #28 to make more atomic commits prior to getting this branch merged.
You can see from the Travis CI logs that even with the Py3 changes from #28, current master has broken python 3 support.