Allow backend to be passed in to sendfile()#33
Open
kaedroho wants to merge 1 commit intojohnsensible:masterfrom
Open
Allow backend to be passed in to sendfile()#33kaedroho wants to merge 1 commit intojohnsensible:masterfrom
kaedroho wants to merge 1 commit intojohnsensible:masterfrom
Conversation
Example:
from sendfile import sendfile
from sendfile.backends.simple import sendfile as simple_sendfile
def myview(request):
...
return sendfile(..., backend=simple_sendfile)
Owner
|
Interesting. Curious as to use case though? The library is just intended to paper over differences between sendfile/nginx/xsendfile etc. Seems odd that you might want a different backend for one particular application? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a
kwargcalledbackendtosendfile(). It allows a different backend to be used for a particular view. It's also useful for third-party apps that want to use sendfile but provide a fallback if their users haven't setSENDFILE_BACKEND.Example: