Conversation
|
Hopefully I'll have a look at this later. My only slight concern is dropping the Django 1.2 support - is it strictly needed? What changes did you do that required this? Not against it per se, just would like to know a bit more about what you've done and why. |
|
My point of view is: if django doesn't support some versions, why I should support them? Django 1.2 (and 1.3) no longer receive security updates or bugfixes, in these case, i think projects using these versions should be updated as soon as possible. Other point is: in certain situations, support older versions, need to be add some conditionals, and permit this conditionals spread on project is a "code smell" :) |
|
Sorry for taking a while to get back to you about this. Busy and all that. In my case I've actually had a site that's still been running Django 1.2. I'm in the process of upgrading it though. I'm also probably going to make use of "select_for_update" when publishing, to avoid race conditions that end up with multiple published objects (e.g. if user double-clicks). Should mean I get a chance to properly look at what you've done this way. cheers, John |
|
Hi, just looking through you're commits now. Can you point out where you've made changes to add Django 1.5 support? There's a lot of noise in here, as this pull request seems to be doing quite a few things. It's interesting to see the travis support etc, but it's clouding the main point of the request. cheers, John |
|
Hi @johnsensible, sorry, but I just saw your message today: ( yes, I made a huge change in the project structure: P but basically what I did was:
and now also possible to use O test.py to run tests |
Hi! I've made some changes: