Redesign chunk LRU with a simpler design#56
Merged
johnramsden merged 4 commits intomainfrom Jan 10, 2026
Merged
Conversation
Rather than trying to keep so much state in sync, simplify the methodology to: * always invalidate based on the lru, completely including the map, now state is always consistent without keeping track of many data structures to see if lru entries are invalid and such * cleaning simply looks at priorities and migrates data accordingly This significantly simplifies the design. To keep the lru consistent we remove the lru entries within the eviction phase for the respective Zone We insert them back and we migrate data Additionally, to exclude corruption from currently writing zones, we remove candidate zones from the open zones list if they are resident
pokej6
approved these changes
Jan 8, 2026
pokej6
left a comment
pokej6
left a comment
There was a problem hiding this comment.
Noticing a lack of tests in this PR but generally changes seem like positive iterations and we chatted in discord. Ship it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign chunk LRU with a simpler design
Rather than trying to keep so much state in sync, simplify the methodology to:
This significantly simplifies the design.
To keep the lru consistent we remove the lru entries within the eviction phase for the respective Zone
We insert them back and we migrate data
Additionally, to exclude corruption from currently writing zones, we remove candidate zones from the open zones list if they are resident