Skip to content

Clarify auto-tune opt-in behavior#50

Open
johnmschoonover wants to merge 1 commit intomainfrom
codex/add-asr-pre-analysis-and-auto-tune-module
Open

Clarify auto-tune opt-in behavior#50
johnmschoonover wants to merge 1 commit intomainfrom
codex/add-asr-pre-analysis-and-auto-tune-module

Conversation

@johnmschoonover
Copy link
Copy Markdown
Owner

Summary

  • note in the CLI docs that auto-tune remains opt-in and must be enabled explicitly
  • update the CLI help text to indicate the flag is disabled by default

Testing

  • not run (documentation-only update)

https://chatgpt.com/codex/tasks/task_e_68eed5092c248333b915aaac7a016bd3

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

segs_iter, info = fw.transcribe(
audio_path,
language="en",
beam_size=asr_cfg.beam_size,

P1 Badge Guard beam_size from None before calling faster-whisper

Auto-tune heuristics set beam_size to None for noisy or mixed audio so sampling can be used, but run_asr forwards that value directly to WhisperModel.transcribe (beam_size=asr_cfg.beam_size). The faster-whisper API’s signature requires an int and defaults to 5; passing None raises a TypeError when auto-tune runs in apply mode. Ensure the call supplies a valid integer (e.g., omit the parameter or coerce to 1) when sampling is desired.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant