Adding extra open parameters: dataBits parity stopBits

[sfkristof]

Hi John!

Please review this mod and tell me if I should change anything.

Thanks,
Kristof

[chilipeppr]

These changes look great. So just to be sure, you can still open ports the
exact same way you've been able to in the past, so we don't break anything,
but if you also specify parity/etc you have to do all 3 new params for it
to work and it will detect that you're doing those params? Case in point,
you can do an open command and not specify a bufferAlgorithm. So you have 3
args. But if you have 4 args its with buffer. In your changes it looks like
you seek 6 args, but do you also allow bufferAlgorithm as an option still
thus 7 args?

On Tue, Sep 6, 2016 at 7:18 AM, sfkristof notifications@github.com wrote:

Hi John!

Please review this mod and tell me if I should change anything.

Thanks,

Kristof

You can view, comment on, or merge this pull request online at:

#54
Commit Summary

• Adding extra open parameters: dataBits parity stopBits

File Changes

• M README.md
  https://github.com/johnlauer/serial-port-json-server/pull/54/files#diff-0
  (1)
• M hub.go
  https://github.com/johnlauer/serial-port-json-server/pull/54/files#diff-1
  (65)
• M serialport.go
  https://github.com/johnlauer/serial-port-json-server/pull/54/files#diff-2
  (9)

Patch Links:

• https://github.com/johnlauer/serial-port-json-server/pull/54.patch
• https://github.com/johnlauer/serial-port-json-server/pull/54.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#54, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHidbXxeKsvQ7AhTBh0gSR2RiGexlqYPks5qnXZHgaJpZM4J146c
.

[sfkristof]

Yes I made it to be backward compatible so if you give just the port baud and optionally the bufferAlgorythm it works as it did in the past and if there are more than 3 params it assumes this new open mode with the 3 extra obligatory parameter like this:
open [bufferAlgorythm]

[sfkristof]

Ooops the less greater then characters are lost.
So the 2nd syntax looks like this:
open port baud databits parity stopbits bufferAlg (optional)
databits: usually 7, 8
parity: NONE, ODD, EVEN, MARK, SPACE
stopbits: 1, 1.5, 2
Example:
open COM1 9600 7 ODD 1.5