Skip to content

fix desktop build workflow #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johncmanuel merged 5 commits into from
Mar 20, 2026
Merged

fix desktop build workflow #2

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98d2ae7
change name
johncmanuel Mar 19, 2026
8fb74ae
try 4.0.0
johncmanuel Mar 19, 2026
c7a9843
try to change node version
johncmanuel Mar 19, 2026
37c2dc7
set up node before wails action
johncmanuel Mar 19, 2026
d6d66a8
fix workflow
johncmanuel Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 7 additions & 21 deletions .github/workflows/desktop-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ env:
jobs:
build:
strategy:
# Failure in one platform build won't impact the others
fail-fast: false
matrix:
build:
Expand All @@ -28,36 +27,23 @@ jobs:
- platform: "darwin/universal"
os: "macos-latest"

# https://github.com/dAppServer/wails-build-action/tree/dev/actions/build/wails2#wails-v2-full-pipeline
runs-on: ${{ matrix.build.os }}
steps:
- name: Checkout
uses: actions/checkout@v4
with:
submodules: recursive

# https://github.com/dAppServer/wails-build-action/tree/dev/actions/build/wails2#wails-v2-full-pipeline
- name: Build wails
uses: host-uk/build@v4
uses: dAppCore/build/actions/build/wails2@v4.0.0
id: build
with:
build-name: ${{ env.APP_NAME }}
build-platform: ${{ matrix.build.platform }}
# go-version: "1.23"
package: true
go-version: "1.23"
# need to keep node at 22.x rather than latest to avoid build issues with
# libwebkit2gtk-4.0-dev (AFAIK, ubuntu 24 drops this specific package). This
# version is needed to work with wails
# node-version: "22.x"

# - name: Build wails
# uses: dAppServer/wails-build-action@v2.2
# id: build
# with:
# build-name: ${{ env.APP_NAME }}
# build-platform: ${{ matrix.build.platform }}
# package: true
# go-version: "1.23"
# # need to keep node at 22.x rather than latest to avoid build issues with
# # libwebkit2gtk-4.0-dev (AFAIK, ubuntu 24 drops this specific package). This
# # version is needed to work with wails
# # See linux installation here: https://wails.io/docs/gettingstarted/installation/
# node-version: "22.x"
# libwebkit2gtk-4.0-dev (AFAIK, ubuntu 24 drops this specific package) as well
# as get Vite to work properly. This version is needed to work with wails
node-version: "22.x"
Loading