Skip to content

Replace hardcoded 'zQ3sh' with SECP256K1_PUBLIC_MULTIBASE_PREFIX constant #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnbillion merged 2 commits into from
Jan 19, 2026
Merged

Replace hardcoded 'zQ3sh' with SECP256K1_PUBLIC_MULTIBASE_PREFIX constant #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f19e2dd
Initial plan
Copilot Jan 18, 2026
5866693
Replace hardcoded 'zQ3sh' with SECP256K1_PUBLIC_MULTIBASE_PREFIX cons…
Copilot Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,9 @@ export async function getRotationPublicKeyMultibase(keyInput: string): Promise<s
// Handle did:key format
if (trimmed.startsWith(DID_KEY_PREFIX)) {
const multibase = trimmed.slice(DID_KEY_PREFIX.length);
if (!multibase.startsWith('zQ3sh')) {
if (!multibase.startsWith(SECP256K1_PUBLIC_MULTIBASE_PREFIX)) {
throw new RotationKeyInputError(
`Invalid rotation key format. Expected a Secp256k1 key starting with 'zQ3sh', got '${multibase.slice(0, 5)}...'`,
`Invalid rotation key format. Expected a Secp256k1 key starting with '${SECP256K1_PUBLIC_MULTIBASE_PREFIX}', got '${multibase.slice(0, 5)}...'`,
);
}
// Validate by decoding and checking structure
Expand Down