Add support for the FAIR_VERIFICATION_KEY environment variable during verification key checking
#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng verification key checking.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for reading the verification key from the FAIR_VERIFICATION_KEY environment variable when using the did verification-key check command, making it more convenient for CI/CD environments where passing keys via environment variables is preferred over files.
Changes:
- Added fallback to
FAIR_VERIFICATION_KEYenvironment variable when neither--keynor--key-fileis provided - Updated help text and error messages to document the new environment variable option
- Added comprehensive documentation in README with usage examples
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/cli/did-verification-key-check.ts |
Added environment variable fallback logic, updated help text, reorganized validation to support three input methods (flag, file, or env var) |
README.md |
Added command to CLI listing, created new documentation section with examples showing all three input methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.