Fix for fdSocket (it's Socket -> IO CInt and it's deprecated)#3
Open
gzh wants to merge 2 commits intojoeyadams:masterfrom
Open
Fix for fdSocket (it's Socket -> IO CInt and it's deprecated)#3gzh wants to merge 2 commits intojoeyadams:masterfrom
gzh wants to merge 2 commits intojoeyadams:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was trying to compile my project which uses Network.Socket.Options on Linux with ghc-8.4.2 and encountered an error saying that fdSocket has the signature of Socket -> IO CInt (not Socket -> CInt as the implementation assumed). I think this is connected with changes to Network module where the signature of fdSocket has changed since version 3.0. Never mind; I also noticed that these days they declare fdSocket as deprecated in favor of withFdSocket function, which is a brand new in network-3.1.0. This PR takes into account for the changed signature of fdSocket and uses the new withFdSocket when possible. The signature of fdSocket in older versions of network package is still respected.