Don't recognize "falls" or "springs" as dates #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This is a little tricky, since you can currently parse things like '2 summers from now' or '2 winters ago'. But I also agree that something like 'the springs are springy' should not be parsed as a date, so I wonder if there's a way to distinguish between the two contexts. |
Owner
|
On second look, maybe you've already considered that? |
Author
|
Yes, I made it so the season has to be "bare" with a plural to prevent recognition. The tests in IcsTest.testSeasonWithModifiers() like "three summers ago" still work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making natty! I'm using it to parse dates embedded in other text, and don't want it to recognize the words "falls" or "springs" as dates unless they have a relative qualifier.