exclude trivia from MetaData's Code property #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@DavidBakerEffendi this effectively removes comments from the parsed (JSON) AST. Wondering if it's too much a drastic change or appreciated? There's some extra context in joernio/joern#5314 |
DavidBakerEffendi
approved these changes
Apr 8, 2025
Contributor
DavidBakerEffendi
left a comment
DavidBakerEffendi
left a comment
There was a problem hiding this comment.
Looks good, and the tests illustrate the concerns from the thread in Joern. Should help with CPG size too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See joernio/joern#5314 for context.
Not the best testing infrastructure. Added it mainly for illustrations purposes. As soon as I have some extra time, I'm happy to start contributing proper tests, re-using the JSON tree for that.