No mutable fields in message records #236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made ILightningSerializable<'T>.Serialize method return deserialized object instead of mutating `this` instance.
Removed `mutable` modifier from all record fields
Added DummyInstanceHolder class for holding ILightningSerializable<'T> instances used for deserialization. Added comment describing why this workaround as well as [<CLIMutable>] annotations on records are needed.
joemphilips
approved these changes
Oct 13, 2022
Owner
joemphilips
left a comment
joemphilips
left a comment
There was a problem hiding this comment.
Thanks. LGTM. Interesting hack.
You are correct that all these mess in deserialization is caused by the lack of static abstract members. But probably we cannot use it in the future even after F#7 gets stable, for the backward compatibility reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87
Made
ILightningSerializable<'T>.Deserializemethod returndeserialized object instead of mutating
thisinstance.Removed
mutablemodifier from all record fields in message types.