Use Citrus framework for email-listener integration tests#1
Open
christophd wants to merge 1 commit intojoelicious:masterfrom
Open
Use Citrus framework for email-listener integration tests#1christophd wants to merge 1 commit intojoelicious:masterfrom
christophd wants to merge 1 commit intojoelicious:masterfrom
Conversation
Owner
|
This is great, I just took a look at the changes and will pull them down into my local. Stepping up Spring should not be a big deal, but I have heard they are dropping OSGi in newer releases..I'll see. I just have to wrap my head around Citrus now. I think it is meant to replace Pax Exam perhaps (or perhaps some of its purpose)? I know within our JBoss Fuse world there has been a movement from Pax Exam to Arquillian, but there is not much in the way of documentation (and therefore can't recommend to clients). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I promised to send you a PR for adding Citrus to the project. I have started to do so for email listener module.
I had some trouble with OSGI and Spring framework version. Citrus works with a newer version of Spring and I did not really know how to add this new version other than overwriting the version in the Maven POM. As I am not very familiar with OSGI I do not know if this is the best way, please review.
Good news: the test is green working with Citrus! Now Citrus is used to send the mail and Citrus receives all records on JMS queue validating the XML message content.
Please let me know how you feel about that!