Expose Head & Tail text for modification#14
Merged
joedaniels29 merged 1 commit intojoedaniels29:masterfrom Jan 11, 2017
Merged
Conversation
By exposing the head & tail text for modification, it's enabling i18n of the clock. Namely an app can pass localized strings to the clock.
Contributor
Author
|
Oops, didn't notice this is a duplicate of #6 |
Owner
|
Thanks for the commit, Usually I'd take the first one, but haven't much time lately, and since travis had issues with #6 and not this, I'm gonna merge this. Thankyou both @megomes and @PhilibertDugas for this fix 👍 And I sincerely would love more PRs. (I'll be better about responding :p ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By exposing the head & tail text for modification, it's enabling i18n of the clock. Namely an app can pass localized strings to the clock.
Thoughts?