Skip to content

Fixed various checkstyle errors. #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AragornIISOA wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed various checkstyle errors. #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/metrocs/HelloAnyone.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ public String sayHello(final String toWhom) {
response = "A special hello to " + toWhom;
}
return response;
}
}
}
1 change: 0 additions & 1 deletion src/metrocs/HelloAnyoneTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
package metrocs;
import org.junit.jupiter.api.Test;
Copy link
Owner

@jody jody Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the "error" is pointing out a shortcoming that needs to be addressed.
We need to consider why the error exists and what it is telling us.
What's actually needed here--to "fix" the "Checkstyle error"--is for there to be an actual test in the file.
Removing the import only "hides" the fact that the test class has no actual tests.
(This is similar to a "TODO:" error which is again indicating that something needs to be added rather than taken away.)


/**
* Tests for class HelloAnyone.
Expand Down
2 changes: 1 addition & 1 deletion src/metrocs/HelloWorld.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ public String sayHello(final String toWhom) {
}
return GREETING + " " + toWhom;
}
}
}